D24577: [dolphin/search] Fix search behavior when selecting "Your Files"

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  In D24577#546629 <https://phabricator.kde.org/D24577#546629>, @iasensio wrote:
  
  > @elvisangelaccio, about your question, reviewing the code, there are four places (apart from setter and getter) where `m_searchPath` is used:
  >
  > 1. For baloo search (l.502), it is only used if `m_everywhere` is not checked, so it would cancel the condition in the getter, returning `m_searchPath` anyway
  > 2. For regular search (l.135), there is a similar condition as in `searchPath()`.
  > 3. Menu action to call an external tool (KFind) (l.423)
  > 4. In the entry point `fromUrlSearch()`, introduced in this patch to reset it on certain paths
  >
  >   I've change the point 2. to reuse `searchPath()` since it was already doing the same thing. In the other cases I think that it is better to keep it at is, but please tell me if you think otherwise.
  
  
  Thanks, LGTM as-is.

REPOSITORY
  R318 Dolphin

BRANCH
  search_everywhere

REVISION DETAIL
  https://phabricator.kde.org/D24577

To: iasensio, #dolphin, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191020/7059c607/attachment.htm>