[frameworks-kio] [Bug 412694] Windows executable should be warned before opening by Wine

[Guo Yunhe]

https://bugs.kde.org/show_bug.cgi?id=412694

Guo Yunhe <i at guoyunhe.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/591cc2a16e3e643165d5d5f4f6
                   |                            |7e2ee4c032217a
             Status|CONFIRMED                   |RESOLVED

--- Comment #1 from Guo Yunhe <i at guoyunhe.me> ---
Git commit 591cc2a16e3e643165d5d5f4f67e2ee4c032217a by Guo Yunhe.
Committed on 16/10/2019 at 08:39.
Pushed by guoyunhe into branch 'master'.

Treat "application/x-ms-dos-executable" as executable on all platforms

Summary:
Because of Wine, *.exe can be executed in almost all desktop platforms.

The dialog will open when a script/exe/binary is clicked.

For scripts, it shows "Open" and "Execute" button. Same as before.

For *.exe on Linux/BSD, it shows only "Execute" button, but it actually does
"Open with Wine".

For native binary, it shows only "Execute" button. This is a new difference. I
think users should never click and run a binary without warning. Here is
already a `showUntrustedProgramWarning` pop up function. But it only popup for
binary without execute bit. If you get a binary from *.tar.gz or *.7z, it may
already have a execute bit and no popup will be appear.

Reviewers: #frameworks, ngraham, dfaure

Reviewed By: ngraham, dfaure

Subscribers: GB_2, ppeter, dfaure, ngraham, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D24463

M  +22   -9    src/widgets/executablefileopendialog.cpp
M  +13   -0    src/widgets/executablefileopendialog_p.h
M  +30   -26   src/widgets/krun.cpp
M  +2    -0    src/widgets/krun_p.h

https://commits.kde.org/kio/591cc2a16e3e643165d5d5f4f67e2ee4c032217a

-- 
You are receiving this mail because:
You are on the CC list for the bug.