D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kitemlistcontroller.cpp:480
> Can you explain the reason for this change?

This function way bugged : 
The two branches of `if (searchFromNextItem)` both looked for the next keyboard with indexForKeyboardSearch(text, currentIndex (the first one with just a +1 modulo).
But when searchFromNextItem is false, we are supposed to start to look for the next indexKeyboard from the start of the list `0`, not from the `currentIndex`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24505

To: meven, elvisangelaccio, #dolphin
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191014/40ed5405/attachment.htm>