D24577: [dolphin/search] Fix search behavior when selecting "Your Files"

Ismael Asensio noreply at phabricator.kde.org
Sat Oct 12 00:50:43 BST 2019


iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Fix the search box forgetting the location where the user was previously searching into.
  
  To do a search on "All Files" instead of setting the `m_searchPath` to `$HOME`, it checks the button state, so the "From Here" location is not lost.
  As an added benefit, selecting "Your Files" when in a non-indexed folder will use the baloo search instead of a fully non-indexed search from $HOME.
  
  This issue is the last remaining one of the series started with D24422 <https://phabricator.kde.org/D24422>, with the purpose of fixing the searchbox parsing and update.

TEST PLAN
  - Toggle between "From Here/Your Files" and navigate between locations
  - The search box remembers the location and keeps a coherent state
  
  F7575402: search_everywhere.png <https://phabricator.kde.org/F7575402>

REPOSITORY
  R318 Dolphin

BRANCH
  search_everywhere

REVISION DETAIL
  https://phabricator.kde.org/D24577

AFFECTED FILES
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: iasensio, #dolphin, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191011/b9e3b4a6/attachment.htm>


More information about the kfm-devel mailing list