D24446: Hide search extra options when not available

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  More info on the i18n markers here: https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt
  
  Looks good otherwise.

INLINE COMMENTS

> dolphinsearchbox.cpp:572
> +    m_facetsToggleButton->setText(
> +           facetsVisible ? i18nc("action:button", "Fewer Options") :
> +                           i18nc("action:button", "More Options"));

`@action:button` as marker.

> dolphinsearchbox.cpp:573
> +           facetsVisible ? i18nc("action:button", "Fewer Options") :
> +                           i18nc("action:button", "More Options"));
> +

`@action:button` as marker.

> dolphinsearchbox.cpp:581
> +        if (!searchInfo.fileIndexingEnabled()) {
> +            m_facetsToggleButton->setToolTip(i18nc("@tooltip", "Advanced search options are not available beacause the file indexing service is disabled."));
> +        } else {

Typo: because (repetead below)

> dolphinsearchbox.cpp:581
> +        if (!searchInfo.fileIndexingEnabled()) {
> +            m_facetsToggleButton->setToolTip(i18nc("@tooltip", "Advanced search options are not available beacause the file indexing service is disabled."));
> +        } else {

`@info:tooltip` as marker.

> dolphinsearchbox.cpp:583
> +        } else {
> +            m_facetsToggleButton->setToolTip(i18nc("@tooltip", "Advanced search options are not available beacause this location is not indexed."));
> +        }

`@info:tooltip` as marker.

> dolphinsearchbox.cpp:586
> +#else
> +        m_facetsToggleButton->setToolTip(i18nc("tooltip", "Advanced search options are not available beacause this version of Dolphin does not support the Baloo file indexer."));
> +#endif

`@info:tooltip` as marker.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24446

To: iasensio, #dolphin, elvisangelaccio, meven, ngraham
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191010/a7fe02fe/attachment.htm>