D23557: Update dolphin tests following place changes D7446

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D23557#543977 <https://phabricator.kde.org/D23557#543977>, @meven wrote:
  
  > In D23557#543918 <https://phabricator.kde.org/D23557#543918>, @elvisangelaccio wrote:
  >
  > > @meven Looks like this patch is not enough: https://build.kde.org/job/Applications/job/dolphin/job/kf5-qt5%20SUSEQt5.12/78/testReport/projectroot.src/tests/placesitemmodeltest/
  > >
  > > Could you have a look?
  >
  >
  > It seems to me the test fails because is uses an older kio version than 5.63 with D7446 <https://phabricator.kde.org/D7446> applied creating "Recently Saved" group instead of group "Recent".
  >
  > > FAIL!  : PlacesItemModelTest::testGroups() Compared values are not the same
  > > 
  > >   Actual   (groups.at(2).second.toString()): "Recently Saved"
  > >   Expected (QStringLiteral("Recent"))      : "Recent"
  >
  > The actual shows that the old "Recently Saved" group was created when it should not have been.
  >
  > I don't know how this jenkins job works, but I would recommend cleaning the cached artifact KIO 5.63.0 for dolphin somehow.
  >  We can alternatively limit this test run only on KF5 >= 5.64
  
  
  Ah I see, then it's ok. We just need to wait for KF5 5.64 on the CI.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23557

To: meven, #dolphin, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191009/d74862d1/attachment.htm>