D24446: Hide search extra options when not available

Méven Car noreply at phabricator.kde.org
Wed Oct 9 12:40:31 BST 2019


meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dolphinsearchbox.cpp:110
>  
> -    m_facetsWidget->setEnabled(isIndexingEnabled());
> +    const bool indexingEnabled = isIndexingEnabled();
> +    m_facetsWidget->setEnabled(indexingEnabled);

You could even add a function for those 4 lines, since it is repeated line 334

REPOSITORY
  R318 Dolphin

BRANCH
  facets_hide

REVISION DETAIL
  https://phabricator.kde.org/D24446

To: iasensio, #dolphin, elvisangelaccio, meven, ngraham
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191009/1aded9d7/attachment.htm>


More information about the kfm-devel mailing list