D24449: [dolphin/search] Avoid unnecesary reloads on setSearchPath

Ismael Asensio noreply at phabricator.kde.org
Sun Oct 6 23:06:25 BST 2019


iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio, meven.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Check in `setSearchPath()` if the `url` passed is already the `searchPath`
  This was causing an effect where reloading the same search URL results on buttons `From Here/Everywhere` toggling.
  See D24422 <https://phabricator.kde.org/D24422>

TEST PLAN
  On your home folder press `Ctrl-F` several times
  Buttons `From Here/Everywhere` should now not toggle each time

REPOSITORY
  R318 Dolphin

BRANCH
  search_parse_noreload

REVISION DETAIL
  https://phabricator.kde.org/D24449

AFFECTED FILES
  src/search/dolphinsearchbox.cpp

To: iasensio, #dolphin, elvisangelaccio, meven
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191006/f5212d3d/attachment.htm>


More information about the kfm-devel mailing list