D24446: Hide search extra options when not available

Ismael Asensio noreply at phabricator.kde.org
Sun Oct 6 19:45:53 BST 2019


iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio, meven, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Hide the search extra options when they are not available, because the current location is not indexed or Baloo is not enabled.
  The button is disabled and shows a tooltip to provide feedback of why it's not available.
  
  FEATURE: 318580
  FEATURE: 408680
  CCBUG: 396898
  FIXED-IN: 19.12

TEST PLAN
  - `Ctrl-F` on a non-indexed location
  - `balooctl disable` and `Ctrl-F` on an indexed location
  
  On both cases the extra options are not shown, the button is disabled and the reason is shown in the tooltip
  The user selection is remembered between indexed locations.

REPOSITORY
  R318 Dolphin

BRANCH
  facets_hide

REVISION DETAIL
  https://phabricator.kde.org/D24446

AFFECTED FILES
  src/search/dolphinsearchbox.cpp
  src/search/dolphinsearchbox.h

To: iasensio, #dolphin, elvisangelaccio, meven, ngraham
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191006/7fecd28c/attachment.htm>


More information about the kfm-devel mailing list