D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#542407 <https://phabricator.kde.org/D7446#542407>, @dfaure wrote:
  
  > This commit breaks `kfileplacesmodeltest`, please take a look.
  >
  > https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/
  
  
  See fix in D24439 <https://phabricator.kde.org/D24439>
  
  The second failure seems to me sporadic, or at least not related :
  
    QDEBUG : KFilePlacesModelTest::testPlaceGroupHidden() Expected: ("/tmp/kfileplacesmodeltest-alwhrs", "trash:/", "remote:/", "/media/nfs", "/foreign", "/media/floppy0", "/media/XO-Y4", "/media/cdrom")
    QDEBUG : KFilePlacesModelTest::testPlaceGroupHidden() Got: ("/tmp/kfileplacesmodeltest-alwhrs", "trash:/", "remote:/", "/media/nfs", "/foreign", "/media/cdrom", "/media/floppy0", "/media/XO-Y4")
    FAIL!  : KFilePlacesModelTest::testPlaceGroupHidden() Compared lists differ at index 5.
       Actual   (placesUrls()): "/media/cdrom"
       Expected (urls): "/media/floppy0"
       Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/autotests/kfileplacesmodeltest.cpp(1091)]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191006/26f174a1/attachment.htm>