D24422: [dolphin] Improve parsing of Baloo query searchString

[Ismael Asensio]

iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio, meven.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  The searchbox panel updates its state on URL changes by parsing the searchURL.
  For baloo queries (`baloosearch:/`) current parsing produces some quirks, such as showing the baloo terms on the user searchbar.
  
  This patch tries to fix the following issues:
  
  - Avoid inserting baloo search terms into the searchbar
  - Avoid inserting quotation marks when searching by filename
  - Add missing parsing of type 'Folder'
  - Do not toggle 'From Here'/'Everywhere' on reloads
  - Reset facetsWidget options when needed
  
  There are two standing issues, which should be addressed on later patches:
  
  - File type is not updated for places' default urls (e.g. baloosearch://videos) because Baloo only fills the query parameter `type` when using a JSON searchString
  - When selecting 'Everywhere' the search path is set to Home folder, so we lose track of which folder the user was previously on

TEST PLAN
    Use and stress the search options in dolphin
    Save some search queries to places panel
    Commute between saved searchs and usual folders (indexed and not indexed) and perform further searches on them

REPOSITORY
  R318 Dolphin

BRANCH
  searchbar_polish

REVISION DETAIL
  https://phabricator.kde.org/D24422

AFFECTED FILES
  src/search/dolphinfacetswidget.cpp
  src/search/dolphinfacetswidget.h
  src/search/dolphinsearchbox.cpp

To: iasensio, #dolphin, elvisangelaccio, meven
Cc: kfm-devel, #baloo, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191005/cb9b3aac/attachment.htm>