D24353: Add actions for switching to a specific tab
Méven Car
noreply at phabricator.kde.org
Thu Oct 3 15:26:33 BST 2019
meven added inline comments.
INLINE COMMENTS
> alexmi wrote in dolphinmainwindow.cpp:1512
> The issue with doing that is that if MaxActivateTabShortcuts ever gets changed to anything higher than 10, then there would be extra calls to try to set shortcuts like Alt + 11.
> I would say it's unlikely it ever gets changed to something higher than 10 but still.
>
> Even when changing that `else` to an `else if`, you would still have to add another check somehow to make sure you're not calling `setDefaultShortcut` when i > 10.
Fair enough I didn't get MaxActivateTabShortcuts could be changed.
REPOSITORY
R318 Dolphin
BRANCH
feature-tab-shortcuts (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24353
To: alexmi, #vdg, #dolphin, ngraham
Cc: meven, ngraham, elvisangelaccio, kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191003/385bf73d/attachment.htm>
More information about the kfm-devel
mailing list