D24376: Update searchbox on URL changes (Fix D24369)

[Ismael Asensio]

iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  In D24369 <https://phabricator.kde.org/D24369> I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to `setSearchModeEnable`.
  
  @elvisangelaccio, if you would like to revert that commit to keep the history cleaner I can rebase this one.
  I'm really sorry for the inconvenience.

TEST PLAN
  - Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed.

REPOSITORY
  R318 Dolphin

BRANCH
  fix_searchbar_update_url

REVISION DETAIL
  https://phabricator.kde.org/D24376

AFFECTED FILES
  src/dolphinviewcontainer.cpp

To: iasensio, #dolphin, elvisangelaccio
Cc: kfm-devel, elvisangelaccio, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191002/11a96248/attachment.htm>