D24369: [dolphin] Update searchbar parameters on URL change

[Elvis Angelaccio]

elvisangelaccio added a comment.


  LGTM

INLINE COMMENTS

> dolphinviewcontainer.cpp:676
>      if (KProtocolManager::supportsListing(url)) {
> -        setSearchModeEnabled(isSearchUrl(url));
> +        const bool _isSearchUrl = isSearchUrl(url);
> +        if (_isSearchUrl) {

Coding style: we never use `_` as prefix for variable names. I'd call this variable just `searchUrl`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D24369

To: iasensio, #dolphin, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191002/0cff0c08/attachment.htm>