D24342: Fix missing setDefaultShortcuts call

David Hallas noreply at phabricator.kde.org
Tue Oct 1 16:27:46 BST 2019


hallas created this revision.
hallas added a reviewer: elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
hallas requested review of this revision.

REVISION SUMMARY
  The commit eec49bc38f4e256b66bf16ee5428c5f5d7e97e25 <https://phabricator.kde.org/R318:eec49bc38f4e256b66bf16ee5428c5f5d7e97e25> cased a warning to
  be emitted when starting Dolphin:
  
  KXMLGUIFactoryPrivate::saveDefaultActionProperties(): Shortcut for action  "go_forward" "&Forward" set with QAction::setShortcut()! Use KActionCollection::setDefaultShortcut(s) instead.
  
  The fix is to call
  actionCollection()->setDefaultShortcuts(m_forwardAction, m_forwardAction->shortcuts());
  so that the default shortcuts are setup.

REPOSITORY
  R318 Dolphin

BRANCH
  fix_missing_set_default_shortcuts

REVISION DETAIL
  https://phabricator.kde.org/D24342

AFFECTED FILES
  src/dolphinmainwindow.cpp

To: hallas, elvisangelaccio
Cc: kfm-devel, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191001/573297bc/attachment.htm>


More information about the kfm-devel mailing list