D25130: [dolphin/search] Search by (multiple) tags

[Nathaniel Graham]

ngraham added a comment.


  Nice, this looks great and works great. Only one real suggestion: disable it when there are no tags. Otherwise clicking on it does nothing.

INLINE COMMENTS

> dolphinfacetswidget.cpp:70
> +    m_tagsSelector = new QToolButton(this);
> +    m_tagsSelector->setIcon(QIcon::fromTheme(QStringLiteral("tag-symbolic")));
> +    m_tagsSelector->setMenu(new QMenu(this));

Just `tag` is fine; the `*-symbolic` icon names are generally for compatibility with GNOME apps.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25130

To: iasensio, elvisangelaccio, ngraham, #dolphin, #vdg
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191129/97429e2f/attachment.htm>