[dolphin] [Bug 412952] Dolphin seems to add extra quotes when deleting trailing quote

Ismael Asensio bugzilla_noreply at kde.org
Thu Nov 28 21:11:07 GMT 2019


https://bugs.kde.org/show_bug.cgi?id=412952

Ismael Asensio <isma.af at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/6776fbc94760188daeca0a
                   |                            |b30e49f645f225f008

--- Comment #4 from Ismael Asensio <isma.af at gmail.com> ---
Git commit 6776fbc94760188daeca0ab30e49f645f225f008 by Ismael Asensio.
Committed on 28/11/2019 at 21:08.
Pushed by iasensio into branch 'release/19.12'.

fix(search): Fix baloo searchString parsing

Summary:
Fix the parsing of Baloo query `searchString` to represent its parameters
properly
in the search box:
# Baloo terms (`rating`, `modified`) are added to the user search text:
{F7575590}
# Extra quotes are added to the search text:
https://bugs.kde.org/show_bug.cgi?id=412952

This revision supersedes D24422, by making the fixes on the new dolphin query
model,
instead of directly on the UI.
FIXED IN: 19.11.90

Test Plan:
  - `bin/dolphinquerytest` passes without `XFAIL`s
  - Dolphin search box is not garbled by search terms or quotes

Reviewers: elvisangelaccio, bruns, ngraham, #dolphin

Reviewed By: elvisangelaccio

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25260

M  +22   -4    src/search/dolphinquery.cpp
M  +0    -18   src/tests/dolphinquerytest.cpp

https://commits.kde.org/dolphin/6776fbc94760188daeca0ab30e49f645f225f008

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the kfm-devel mailing list