[dolphin] [Bug 414402] Dolphin service fails to spawn a new instance of Dolphin

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=414402

Elvis Angelaccio <elvis.angelaccio at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |19.12.0
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/089a05b4edfd7a70e50ed7
                   |                            |d8b158cbcc50538d36
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Elvis Angelaccio <elvis.angelaccio at kde.org> ---
Git commit 089a05b4edfd7a70e50ed7d8b158cbcc50538d36 by Elvis Angelaccio.
Committed on 28/11/2019 at 20:52.
Pushed by elvisangelaccio into branch 'release/19.12'.

Force dbus introspection on the Dolphin_1 object

Summary:
QtDBus caches known interfaces when passing a non-empty interface name
to the QDbusInterface constructor. This is an issue when calling the
FileManager1 methods more than once, because `preferred` could be a
valid interface from the cache, but it would later fail to call the
`openFiles`/`openDirectories` methods on the main window.

By passing an empty interface name, we prevent QtDBus from using the
cache so that we always get an invalid interface when calling the
FileManager1 methods on a daemonized dolphin process (that doesn't have
the Dolphin_1 dbus object).
FIXED-IN: 19.12.0

Test Plan:
1. dolphin --daemon
2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders
"/tmp" ""
3. Close the dolphin window that was just opened.
4. Start a normal dolphin process
5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders
"/tmp" ""
6. Close again the dolphin window
7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders
"/tmp" ""

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25510

M  +1    -1    src/global.cpp

https://commits.kde.org/dolphin/089a05b4edfd7a70e50ed7d8b158cbcc50538d36

-- 
You are receiving this mail because:
You are on the CC list for the bug.