D25510: Force dbus introspection on the Dolphin_1 object

[Elvis Angelaccio]

elvisangelaccio created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  QtDBus caches known interfaces when passing a non-empty interface name
  to the QDbusInterface constructor. This is an issue when calling the
  FileManager1 methods more than once, because `preferred` could be a
  valid interface from the cache, but it would later fail to call the
  `openFiles`/`openDirectories` methods on the main window.
  
  By passing an empty interface name, we prevent QtDBus from using the
  cache so that we always get an invalid interface when calling the
  FileManager1 methods on a daemonized dolphin process (that doesn't have
  the Dolphin_1 dbus object).
  
  BUG: 414402
  FIXED-IN: 19.12.0

TEST PLAN
  1. dolphin --daemon
  2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
  3. Close the dolphin window that was just opened.
  4. Start a normal dolphin process
  5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
  6. Close again the dolphin window
  7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""

REPOSITORY
  R318 Dolphin

BRANCH
  release/19.12

REVISION DETAIL
  https://phabricator.kde.org/D25510

AFFECTED FILES
  src/global.cpp

To: elvisangelaccio
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191124/3d40ef7c/attachment.htm>