D25416: fix(search): Correctly parse filename and/or content search

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinquery.cpp:48
> +
> +    QString stripQuotes(const QString& text) {
> +        QString cleanedText = text;

Coding style: opening brace to the next line

> dolphinquery.cpp:59
> +
> +    QStringList splitOutsideQuotes(const QString& text) {
> +        const QRegularExpression subTermsRegExp("([^ ]*\"[^\"]*\"|(?<= |^)[^ ]+(?= |$))");

Same here

> dolphinquery.cpp:64
> +        QStringList textParts;
> +        while(subTermsMatchIterator.hasNext()) {
> +            textParts << subTermsMatchIterator.next().captured(0);

Space after `while`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25416

To: iasensio, elvisangelaccio, bruns, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191123/6cce7262/attachment.htm>