D25260: fix(search): Fix baloo searchString parsing

Ismael Asensio noreply at phabricator.kde.org
Fri Nov 15 22:12:11 GMT 2019


iasensio added inline comments.

INLINE COMMENTS

> bruns wrote in dolphinsearchbox.cpp:525
> That would be wrong.
> 
> The parser should not break what has been typed and interfere with the user.

I've given it a thought and to do it properly it will require some changes in the model, and a new test case would be handful. If you'd prefer I can split the content/filename part (case 3.) from the current patch, both in model and ui, and come with a better solution in a later one.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25260

To: iasensio, elvisangelaccio, bruns, ngraham, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191115/1f7bcdb9/attachment.htm>


More information about the kfm-devel mailing list