D23507: Replace custom single threaded merge sort with std::stable_sort

Méven Car noreply at phabricator.kde.org
Wed Nov 13 12:43:53 GMT 2019


meven added a comment.


  Seems sane to me and nice since it removes some code.

INLINE COMMENTS

> kfileitemmodelsortalgorithm.h:84
>  
> +/**
> + * Uses up to \a numberOfThreads threads to sort the items between

Could you keep this function line at line 30 instead of moving, so that the diff actually shows what changed.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D23507

To: fabiank, #dolphin, elvisangelaccio
Cc: meven, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191113/adf42fce/attachment.htm>


More information about the kfm-devel mailing list