D25257: refactor(search): De-couple baloo URL parsing logic from UI

[Stefan Brüns]

bruns added a comment.


  In D25257#561786 <https://phabricator.kde.org/D25257#561786>, @iasensio wrote:
  
  > In D25257#561782 <https://phabricator.kde.org/D25257#561782>, @bruns wrote:
  >
  > > Please remove the Depends D25255 <https://phabricator.kde.org/D25255> from the summary, this one is independent.
  >
  >
  > I'm afraid it won't work well without that, because it handles the empty case for `type()`.
  >  For the sake of simplicity, I could also abandon D25255 <https://phabricator.kde.org/D25255> and keep the change here.
  
  
  Without D25255 <https://phabricator.kde.org/D25255>, the type will not be reset to "Any", just as before.
  
  After this has landed, the unit tests should go in, then D25255 <https://phabricator.kde.org/D25255> (amended by the unit test change, XFAIL--).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191113/b297e3d7/attachment.htm>