D25257: refactor(search): De-couple baloo URL parsing logic from UI

Ismael Asensio noreply at phabricator.kde.org
Tue Nov 12 23:15:09 GMT 2019


iasensio added a comment.


  In D25257#561782 <https://phabricator.kde.org/D25257#561782>, @bruns wrote:
  
  > Please remove the Depends D25255 <https://phabricator.kde.org/D25255> from the summary, this one is independent.
  
  
  I'm afraid it won't work well without that, because it handles the empty case for `type()`.
  For the sake of simplicity, I could also abandon D25255 <https://phabricator.kde.org/D25255> and keep the change here.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinquerymodel.h:39
> I see, then please put this information in the documentation of this method ;)

Kind of broke Phabricator. ⚙  I updated to this:

  /** @return the user text part of the query, to be shown in the searchbar */
  QString text() const;

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191112/ce25141c/attachment.htm>


More information about the kfm-devel mailing list