D25257: refactor(search): De-couple baloo URL parsing logic from UI

Ismael Asensio noreply at phabricator.kde.org
Tue Nov 12 22:24:48 GMT 2019


iasensio added a comment.


  I changed the filenames to address a change in the class name, and it seems that phab didn't preserve the inline comments, sorry.
  I've tried to address the majority of them, now with better understanding of @bruns intentions about the refactor itself.
  Thanks for the insightful reviews.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191112/16e4fca4/attachment.htm>


More information about the kfm-devel mailing list