D25257: refactor(search): De-couple baloo URL parsing logic from UI

Ismael Asensio noreply at phabricator.kde.org
Mon Nov 11 18:25:04 GMT 2019


iasensio added inline comments.

INLINE COMMENTS

> bruns wrote in dolphinquerymodel.h:45
> Does not access `DolphinQueryModel`, so can be deleted here and declared in an anonymous namespace in `dolphinquerymodel.cpp`

I'm not really sure about this. Wouldn't it be useful to set the terms here and access them from the outside to avoid duplication, for instance, in `DolphinFacetsWidget`itself?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/537e2012/attachment.htm>


More information about the kfm-devel mailing list