D24433: Move URL parsing methods from kioslave to query object

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Nov 11 15:05:26 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> query.cpp:317
> +{
> +    const QString jsonQuery(QStringLiteral("{\"dayFilter\": 0,\
> +                                             \"monthFilter\": 0, \

dayFilter/monthFilter/yearFilter are pointless, as they just default, but have to be parsed in `fromJSON`.

> query.cpp:329
> +    if (path == QLatin1String("/documents")) {
> +        return jsonQueryForType(QStringLiteral("Document"));
> +    } else if (path.endsWith(QLatin1String("/images"))) {

can be replaced by `QStringLiteral("{\"type\":[\"Document\"]}")`, dito below.

REPOSITORY
  R293 Baloo

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

To: iasensio, #baloo, meven, ngraham, astippich
Cc: bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/c16b3060/attachment.htm>


More information about the kfm-devel mailing list