D25257: refactor(search): De-couple baloo URL parsing logic from UI

[Stefan Brüns]

bruns added a comment.


  Please add a comment to the summary that the parser logic is exactly kept as is.

INLINE COMMENTS

> dolphinquerymodel.cpp:62
> +    static const QList<QLatin1String> searchTokens = QList<QLatin1String>()
> +        << QLatin1String("modified>=")
> +        << QLatin1String("rating>=");

add a comment this is a copy of the DolphinFacetsWidget::isRatingTerm() method.

> dolphinquerymodel.h:43
> +    QString customDir() const {return m_customDir;};
> +    bool isGlobalSearch() const {return m_customDir.isEmpty();};
> +

keep the API small, no need for this function.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25257

To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/25ce3f71/attachment.htm>