D25260: fix(search): Fix baloo searchString parsing

[Ismael Asensio]

iasensio created this revision.
iasensio added reviewers: elvisangelaccio, bruns, ngraham, Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  Fix the parsing of Baloo query `searchString` to represent its parameters properly in the search box:
  
  1. Baloo terms (`rating`, `modified`) are added to the user search text: F7575590: search_parse_frombaloo.png <https://phabricator.kde.org/F7575590>
  2. Extra quotes are added to the search text: https://bugs.kde.org/show_bug.cgi?id=
  3. Doesn't properly selects `Filename` or `Content` (just uses previous selection)
  
  This revision supersedes D24422 <https://phabricator.kde.org/D24422>, by making the fixes on the new dolphin query model, instead of directly on the UI.
  
  BUG: 412952
  FIXED IN: 19.12 / 20.04?
  
  Depends on: D25258 <https://phabricator.kde.org/D25258>

TEST PLAN
  `bin/dolphinsearchboxtest`

REPOSITORY
  R318 Dolphin

BRANCH
  fix_baloo_parsing

REVISION DETAIL
  https://phabricator.kde.org/D25260

AFFECTED FILES
  src/search/dolphinquerymodel.cpp
  src/search/dolphinquerymodel.h
  src/search/dolphinsearchbox.cpp
  src/tests/dolphinsearchboxtest.cpp

To: iasensio, elvisangelaccio, bruns, ngraham, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/03f26b04/attachment.htm>