D25257: refactor(search): De-couple baloo URL parsing logic from UI
Ismael Asensio
noreply at phabricator.kde.org
Mon Nov 11 13:01:40 GMT 2019
iasensio created this revision.
iasensio added reviewers: Dolphin, elvisangelaccio, bruns.
iasensio added a project: Dolphin.
iasensio requested review of this revision.
REVISION SUMMARY
Extracts the logic that parses `baloosearch:` Url into a new model class.
The search box UI is later updated using the model fields.
This refactor has been proposed by @bruns in the review of D24422 <https://phabricator.kde.org/D24422>, as it largely simplifies the unit tests and further expansion/improvements
Depends on: D25255 <https://phabricator.kde.org/D25255>
TEST PLAN
No behavior changes.
Test case is added in the follow-up revision
REPOSITORY
R318 Dolphin
BRANCH
model_view_parsing
REVISION DETAIL
https://phabricator.kde.org/D25257
AFFECTED FILES
src/CMakeLists.txt
src/search/dolphinfacetswidget.cpp
src/search/dolphinquerymodel.cpp
src/search/dolphinquerymodel.h
src/search/dolphinsearchbox.cpp
src/search/dolphinsearchbox.h
To: iasensio, #dolphin, elvisangelaccio, bruns
Cc: bruns, kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/50afdaf9/attachment.htm>
More information about the kfm-devel
mailing list