D25255: fix(search): Allow to set empty type

Ismael Asensio noreply at phabricator.kde.org
Mon Nov 11 12:36:55 GMT 2019


iasensio created this revision.
iasensio added reviewers: elvisangelaccio, Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  This small patch allows to set and empty `type` to the extended options, which will set the `Any Type` option (index 0).
  It doesn't make any change in current code, since this case is not called, but it helps simplifying follow-up patches.

TEST PLAN
  No behavior changes with current code.
  Calling `setFacetsType(QString())` actually sets the first option (`Any Type`)

REPOSITORY
  R318 Dolphin

BRANCH
  facets_empty_type

REVISION DETAIL
  https://phabricator.kde.org/D25255

AFFECTED FILES
  src/search/dolphinfacetswidget.cpp

To: iasensio, elvisangelaccio, #dolphin
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191111/d104b751/attachment.htm>


More information about the kfm-devel mailing list