D25230: PlacesItemModel: remove redundant set of properties

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: Dolphin, meven, ngraham.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  The text, icon and url properties are already set in
  PlasesItem::setBookmark(), so there is no need to set them here.
  
  The OnlyInApp properties is part of the KBookmark object that we are
  going to set to the place item, so there is need to set it here either.

TEST PLAN
  - Open both dolphin and the Plasma file dialog in some app
  - Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog
  - Check whether the place in dolphin keeps getting updated accordingly

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25230

AFFECTED FILES
  src/panels/places/placesitem.cpp
  src/panels/places/placesitemmodel.cpp

To: elvisangelaccio, #dolphin, meven, ngraham
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191109/681e2f04/attachment.htm>