D25218: [Status Bar] Remove file status Timer

[Méven Car]

meven added a comment.


  In D25218#560422 <https://phabricator.kde.org/D25218#560422>, @elvisangelaccio wrote:
  
  > In D25218#560389 <https://phabricator.kde.org/D25218#560389>, @meven wrote:
  >
  > > I am not so sure about this 150 ms delay.
  > >  When navigating with the keyboard, it is quite noticeable.
  > >  So in the meantime, I am gonna reduce this delay to 50 ms.
  > >
  > > Removing it altogether might be appropriate.
  > >
  > > Just as a reminder, the information panel delay is mostly due to technicalities : thumbnail generation and metadata extraction are costly.
  > >  Whereas here we don't have such reasons to limit text refreshing.
  >
  >
  > Another thing to mention is that the information panel is not even visible by default.
  >
  > This 1s timer was added by 1ea09b24e16d98ac2f1033b <https://phabricator.kde.org/R318:1ea09b24e16d98ac2f1033b21462323fb295ae2f> without explaining why, so I think we can safely remove it. So I'd restore the previous version of this patch that removed the timer altogether.
  
  
  I did remove the 1s timer similarly to state before 1ea09b24e16d98ac2f1033b <https://phabricator.kde.org/R318:1ea09b24e16d98ac2f1033b21462323fb295ae2f>.
  
  But as @ngraham suggested, I added a delay before a new text is displayed in the status bar to avoid flickering similarly to the information panel.
  The delay is currently of 50ms.
  That is what my last comment was about, not about the 1s timer which I already removed.
  
  Do we understand each other ?
  Do you have an opinion about this update delay, taking into account my last comment ?
  Or did you mean LGTM ?

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25218

To: meven, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191109/72b06e08/attachment.htm>