D25170: make the libssh finder ensure the new ssh target is set

Harald Sitter noreply at phabricator.kde.org
Wed Nov 6 12:59:09 GMT 2019


sitter created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  starting with 0.9.2 the libssh cmake config defines a new ssh imported
  target, use this as the new gold standard and ensure older versions
  are compatible
  
  broken ubuntu: no cmake config -> manual finder -> target injected
  0.9.0 and earlier: cmake config -> target injected
  0.9.2: cmake config -> target already defined; noop
  
  (0.9.1 is broken as it neither matches the old nor the new expectation)

TEST PLAN
  no cmake config -> target injected
  older cmake config -> target injected
  newer cmake config (with merge request) -> noop

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25170

AFFECTED FILES
  cmake/Findlibssh.cmake
  sftp/CMakeLists.txt

To: sitter
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191106/ebf97609/attachment.htm>


More information about the kfm-devel mailing list