D25028: Make the search box more compact

Elvis Angelaccio noreply at phabricator.kde.org
Sat Nov 2 12:14:35 GMT 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinfacetswidget.cpp:68
> +    topLayout->setContentsMargins(0, 0, 0, 0);
> +    topLayout->setSpacing(2);
>      topLayout->addWidget(m_typeSelector);

Please do not hardcode numbers in the code. Use a variable in `global.h` instead, where we already have a `VERTICAL_SPACER_HEIGHT` constant.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D25028

To: iasensio, elvisangelaccio, ngraham, #dolphin, #vdg
Cc: kfm-devel, pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20191102/30cfbf32/attachment.htm>


More information about the kfm-devel mailing list