D21466: Recommend rebooting after installing Samba

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks, Dolphin, apol.
ngraham requested review of this revision.

REVISION SUMMARY
  After Samba is installed, very frequently it will not work correctly until the machine is
  rebooted. One potential reason is when the installed package has made group membership
  changes, which only take effect after a reboot.
  
  This patch implements a reboot recommendation along with a button to reboot the machine.
  Both are shown immediately after Samba has been installed.
  
  Because some expert users may understand the technical details of what's going on, the
  reboot is only recommended, not required. If the window is closed and then re-opened,
  the normal Samba sharing configuration UI is displayed instead of the reboot prompt.
  
  Added a new function rather than using a Lambda because it may be useful for additional
  purposes too (e.g. https://bugs.kde.org/show_bug.cgi?id=407846)
  
  FEATURE: 407845
  FIXED-IN: 19.08.0

TEST PLAN
  http://s1.webmshare.com/Ry55q.webm (not uploaded to Phab due to file size limit)
  
  1. Remove Samba
  2. Go to share a folder
  3. Click "Install Samba"
  4. After the installation has completed, click the "Restart" button and see that the machine reboots
  
  5. Remove Samba again
  6. Go to share a folder
  7. Click "Install Samba"
  8. Close the window and re-open it instead of rebooting as recommended
  9. See that the Samba sharing config UI is all there

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  recommend-rebooting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21466

AFFECTED FILES
  samba/filepropertiesplugin/sambausershareplugin.cpp
  samba/filepropertiesplugin/sambausershareplugin.h

To: ngraham, #vdg, #frameworks, #dolphin, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190528/7c1fa305/attachment.htm>