D16648: Open externally called files/directories in new tabs

Elvis Angelaccio noreply at phabricator.kde.org
Sat May 25 11:11:33 BST 2019


elvisangelaccio added a comment.


  Almost there :)

INLINE COMMENTS

> dolphinmainwindow.cpp:1730
> +{
> +    if (m_tabWidget->getIndexByUrl(QUrl(url)) >= 0) {
> +        return true;

We should use `QUrl::fromUserInput()` here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16648

To: feverfew, #dolphin, elvisangelaccio
Cc: dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190525/fc5c65be/attachment.htm>


More information about the kfm-devel mailing list