D16648: Open externally called files/directories in new tabs

Alexander Saoutkin noreply at phabricator.kde.org
Thu May 23 11:54:06 BST 2019


feverfew added inline comments.

INLINE COMMENTS

> fvogt wrote in global.cpp:127
> `if (isUrlOpen.isValid() && isUrlOpen.value()) {`

This might be dangerous? The wording of the docs doesn't make it too clear: https://doc.qt.io/qt-5/qdbusreply.html#value

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16648

To: feverfew, #dolphin, elvisangelaccio
Cc: dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190523/c1c97623/attachment.htm>


More information about the kfm-devel mailing list