D16648: Open externally called files/directories in new tabs

[Alexander Saoutkin]

feverfew added a subscriber: dfaure.
feverfew added a comment.


  In D16648#468028 <https://phabricator.kde.org/D16648#468028>, @fvogt wrote:
  
  > In D16648#467893 <https://phabricator.kde.org/D16648#467893>, @feverfew wrote:
  >
  > > In D16648#467854 <https://phabricator.kde.org/D16648#467854>, @fvogt wrote:
  > >
  > > > It looks like several QUrls were changed to QString here, why? Most of those QStrings, if not all, actually contain URLs.
  > >
  > >
  > > If I remember correctly Qt methods that are publicised on DBus cannot have parameters as QList<QUrl>, hence I had to use QStringList. This seems to happen often enough that Qt even has helper functions to do the conversion. There are some more conversions to avoid unnecessarily changing method signatures of existing functions.
  >
  >
  > Not quite sure whether Qt supports that, but you could overload the methods of MainWindow so that the slots accept a QStringList and just pass it on.
  
  
  `QUrl::fromStringList` and `QUrl::toStringList` were created for the express purpose of dealing with DBus calls: https://gitlab.com/pteam/pteam-qtbase/commit/6b9545a980f09d8fb034d930cfe67f6110357d0c.
  In fact @dfaure was the one who created these functions himself :)
  I think I'll stick with using those static methods unless there is a different reason to objection.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16648

To: feverfew, #dolphin, elvisangelaccio
Cc: dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190521/ac646dd6/attachment.htm>