D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points

[Noah Davis]

ndavis added a comment.


  In D21312#467698 <https://phabricator.kde.org/D21312#467698>, @ngraham wrote:
  
  > +1 for restoring the feature, which is very useful! I've wanted this myself many times, so thanks for submitting this! However I'll admit I'm not super thrilled about having the capacity indicator bar always visible. I can't quite put my finger on why, but something about it feels a bit off. Maybe that's why the original only appeared on hover? But that's problematic in an era where we need to be designing for touch-friendliness. Maybe it could be a pie chart to the right of the icon but left of the text? Or maybe it's fine as-is and I'm just being a stick-in-the-mud.
  >
  > Either way, adding #VDG <https://phabricator.kde.org/tag/vdg/> for comment.
  
  
  I agree that something about it seems off, but I think a horizontal bar is easier to read than a pie chart. A simple percentage with a background to make it stand out could work if we need something less wide than the bar.
  
  In D21312#467728 <https://phabricator.kde.org/D21312#467728>, @filipf wrote:
  
  > In D21312#467721 <https://phabricator.kde.org/D21312#467721>, @ndavis wrote:
  >
  > > Can you use the NegativeText color from the colorscheme instead of a custom danger color?
  >
  >
  > Although some color schemes have ... odd colors set for NegativeText (e.g pink in Wonton Soup), I agree that it would be better to have it follow the color scheme.
  
  
  We shouldn't hardcode colors to work around problems with specific colorschemes anyway.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21312

To: Zren, #dolphin, #vdg
Cc: filipf, abetts, ndavis, ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190521/e13d7781/attachment.htm>