D21177: When filter bar is focused, switch to view when tab key is pressed

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Various people have requested that the tab key move keyboard focus from the filter bar's
  text edit field to the main view. It already does this when the Enter and return keys
  are pressed, but apparently this is not very intuitive and people expect Tab to work too.
  
  This patch makes that behavior possible by moving the Lock button to the left of the
  text edit field, and re-arranging the code so that the filter bar is initialized first.
  This works because Qt assigns tab ordering by default according to the order of widget
  construction. So if we simply construct the main view right after the filter bar, then
  the tab ordering is set up this way automatically.
  
  BUG: 403379
  BUG: 403356
  FIXED-IN: 19.08.0

TEST PLAN
  1. Activate Filter bar
  2. Hit Tab key
  3. View has become focused
  4. Play around in Dolphin for a while and notice no regressions or crashes

REPOSITORY
  R318 Dolphin

BRANCH
  tab-from-filter-bar-into-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21177

AFFECTED FILES
  src/dolphinviewcontainer.cpp
  src/filterbar/filterbar.cpp

To: ngraham, #dolphin
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190513/c4f272a7/attachment.htm>