D20024: Fixes crash when hiding devices

David Hallas noreply at phabricator.kde.org
Mon May 6 18:35:42 BST 2019


hallas marked an inline comment as done.
hallas added a comment.


  In D20024#460684 <https://phabricator.kde.org/D20024#460684>, @elvisangelaccio wrote:
  
  > Please also update the commit message (the fix is now different).
  
  
  Argh! I accidentally created a new diff instead: D21050 <https://phabricator.kde.org/D21050> - I hope that is ok?

INLINE COMMENTS

> elvisangelaccio wrote in kstandarditem.cpp:48
> Shouldn't this be `QObject(item->parent())` ?

I have removed this constructor instead since nobody uses it anyway :/

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20024

To: hallas, #dolphin, elvisangelaccio
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190506/6d3ad292/attachment.htm>


More information about the kfm-devel mailing list