D20052: Make tabs rename-able

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> dolphintabwidget.cpp:120
>      for (int i = 0; i < tabCount; ++i) {
> -        tabBar()->setTabText(i, tabName(tabPageAt(i)));
> +        auto uuid = tabPageAt(i)->uuid();
> +        if (m_tabNames.contains(uuid)) {

Maybe this logic should be moved to the `tabName` function instead?

> dolphintabwidget.h:226
>      int m_lastViewedTab;
> +    QMap<QUuid, QString> m_tabNames;
>  };

Why is this information stored here and not in the individual Tab Pages? If a Tab Page knew it's own name, you wouldn't need the UUID stuff so it could simplify the code quite a bit.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20052

To: krutovmikhail, #dolphin, ngraham, elvisangelaccio
Cc: hallas, elvisangelaccio, ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190330/35de2089/attachment.htm>