D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

[Robert Hoffmann]

hoffmannrobert marked 4 inline comments as done.
hoffmannrobert added inline comments.

INLINE COMMENTS

> dfaure wrote in kfileitem.cpp:361
> What about the other way around? I think this needs the symmetrical test to call item.init() if needed
> (and the corresponding unittest, write it first)

You're right, fixed, unittest added.

> dfaure wrote in kfileitem.cpp:730
> This use of d->m_entry needs a call to init(), no?

It does, now there via entry(). And ACL() needs init(), too, it's in hasExtendedACL() there.

> dfaure wrote in kfileitem.cpp:766
> This kind of method (which only uses d->m_entry in one place) could be simplified by just doing
> 
>   return entry().stringValue(....);
> 
> Then the init() would happen inside entry().
> 
> This would work in user() just above, too.

And in defaultACL(), setLocalPath(), linkDest(), hasExtendedACL() and overlays().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19887

To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190329/b600f8cb/attachment.htm>