D20052: Make tabs rename-able

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, this generally works very nicely. I found a big bug though: when you rename a tab and then move it to another position on the tab bar, the tab in its old position no longer updates its name when the user navigates around in that tab, and the renamed tab inappropriately does update its name as the user navigates around.

INLINE COMMENTS

> dolphintabbar.cpp:166
> +        } else if (selectedAction == renameTabAction) {
> +            bool result=false;
> +            QString newTabName = QInputDialog::getText(this, 

Spaces around the equals sign

> dolphintabbar.cpp:168
> +            QString newTabName = QInputDialog::getText(this, 
> +                i18n("Rename tab"), i18n("New tab name"), QLineEdit::Normal, tabText(index), &result
> +            );

"Rename Tab" (use title case for window titles)

> dolphintabwidget.cpp:33
>  #include <QDropEvent>
> +#include <QDebug>
>  

Don't want this in production code

> dolphintabwidget.h:177
> +    
>  
>  private slots:

Unnecessary whitespace change

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20052

To: krutovmikhail, #dolphin, ngraham
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190326/888701a7/attachment.htm>