D20049: Fix unexpected behaviour when calling dolphin with a file as an argument
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Mar 25 23:36:50 GMT 2019
apol added a comment.
I'm not an expert in dolphin but other than that it looks good to me. +1
Thanks!
INLINE COMMENTS
> main.cpp:142
> }
> + QList<QUrl> urlDirectories = QList<QUrl>();
> + QList<QUrl> urlRegularFiles = QList<QUrl>();
No need to initialize with an empty list, it will be filled by default.
Just leave `QList<QUrl> urlDirectories;`
> main.cpp:164
> } else {
> - mainWindow->openDirectories(urls, splitView);
> + if (urlDirectories.size()>0) {
> + mainWindow->openDirectories(urlDirectories, splitView);
Use `!urlDirectories.isEmpty()`, it's a bit more direct.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D20049
To: krutovmikhail, #dolphin, elvisangelaccio
Cc: apol, elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190325/b55a60ff/attachment.htm>
More information about the kfm-devel
mailing list