D20024: Fixes crash when hiding devices

[David Hallas]

hallas created this revision.
hallas added reviewers: Dolphin, elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes crash when hiding devices. The crash is caused by
  KStandardItem::setDataValue which calls the
  KStandardItemModel::onItemChanged function, and that function will
  delete the KStandardItem if the data value being set is the hidden
  attribute being set to true. So therefore this function call has to be
  last.

TEST PLAN
  Right click a device in the places panel and select hide
  Right click the places panel and select show hidden
  Right click the hidden device and select show
  Right click the same device and select hide
  
  BUG: 403064

REPOSITORY
  R318 Dolphin

BRANCH
  fix_crash_when_hiding_devices (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20024

AFFECTED FILES
  src/kitemviews/kstandarditem.cpp

To: hallas, #dolphin, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190324/2c5b9585/attachment.htm>