D19904: Prompt user to save/discard changes upon closing config dialog

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinsettingsdialog.cpp:163
> +    const auto response = KMessageBox::warningYesNoCancel(this,
> +                                        i18n("You have have unsaved changes.\nDo you want to apply the changes or discard them?"),
> +                                        i18n("Warning"),

Please use semantic markup and replace `\n` with `<nl/>`.

See https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup for more details.

> dolphinsettingsdialog.h:52
> +private:
> +    void closeEvent(QCloseEvent* event) override;
> +

`QWidget::closeEvent()` is `protected`, I'd make it protected also here.

> dolphinsettingsdialog.h:54
> +
>  private:
>      static SettingsPageBase *createTrashSettingsPage(QWidget *parent);

There is already a `private` section in this class.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19904

To: amhndu, #dolphin, elvisangelaccio
Cc: ngraham, elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190324/0e721244/attachment.htm>