D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled

Méven Car noreply at phabricator.kde.org
Sun Mar 24 08:40:53 GMT 2019


meven marked 3 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in informationpanelcontent.cpp:177-186
> Unrelated whitespace changes.

It is related : this code is now in a if statement starting line 157.

> elvisangelaccio wrote in informationpanelcontent.cpp:200
> Unrelated whitespace changes.

This is the correct spacing. Have a look at the side-by-side view.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19844

To: meven, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190324/938c1039/attachment.htm>


More information about the kfm-devel mailing list