D19844: [InformationPanel] Hide the video when the preview is disabled, avoid computing the preview when it is disabled

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> informationpanel.cpp:212
>      }
> -    if (action == dateformatAction) {
> +    else if (action == dateformatAction) {
>          int dateFormat = static_cast<int>(isChecked ? Baloo::DateFormats::ShortFormat : Baloo::DateFormats::LongFormat);

This looks like an unrelated cosmetic change that could go in another commit.

> informationpanelcontent.cpp:177-186
> +            if (!m_item.isDir()) {
> +                m_outdatedPreviewTimer->start();
> +            }
>  
> -        QStringList plugins = KIO::PreviewJob::availablePlugins();
> -        m_previewJob = new KIO::PreviewJob(KFileItemList() << item,
> -                                           QSize(m_preview->width(), m_preview->height()),
> -                                           &plugins);
> -        m_previewJob->setScaleType(KIO::PreviewJob::Unscaled);
> -        m_previewJob->setIgnoreMaximumSize(item.isLocalFile());
> -        if (m_previewJob->uiDelegate()) {
> -            KJobWidgets::setWindow(m_previewJob, this);
> -        }
> +            QStringList plugins = KIO::PreviewJob::availablePlugins();
> +            m_previewJob = new KIO::PreviewJob(KFileItemList() << m_item,
> +                                               QSize(m_preview->width(), m_preview->height()),

Unrelated whitespace changes.

> informationpanelcontent.cpp:200
> +                m_phononWidget->show();
> +                m_phononWidget->setUrl(m_item.targetUrl());
>                  m_phononWidget->setVideoSize(m_preview->size());

Unrelated whitespace changes.

> informationpanelcontent.h:77
>  
> +    void refreshPreview();
> +

Please add documentation for this method.

> informationpanelcontent.h:84-87
>       * Is invoked after the file meta data configuration dialog has been
>       * closed and refreshes the visibility of the meta data.
>       */
>      void refreshMetaData();

Please update the documentation, as `refreshMetaData()` won't refresh the visibility of the metadata anymore after this patch.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19844

To: meven, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190323/fe4c0f31/attachment.htm>